-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add pyproject.toml #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add pyproject.toml #2465
Conversation
87708dc to
86557ec
Compare
86557ec to
940b5d5
Compare
Black automatically picks up "requires-python" value from pyproject.toml, this argument is no longer needed.
ed27db6 to
b6eed88
Compare
| "sentry-sdk==2.49.0", | ||
| ] | ||
|
|
||
| # TODO: Consider merging with dev group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think test & dev are really the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@django/django-website How do you feel here?
| version = "0.0.1" | ||
| description = "Source code to djangoproject.com" | ||
| requires-python = ">=3.12" | ||
| classifiers = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need these. They're for pypi metadata only I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest usecase is PyPI metadata but I think they are useful for communicating what is supported. Can also be used for generating badges: https://shields.io/badges/py-pi-versions-from-framework-classifiers
Python classifiers are pushed by the default pyproject-fmt setup. It can be disabled, but I see no harm.
I can remove them, there is not much benefit, but I'm on the side of keeping them documentation/communication purposes.
|
There is already a conflict with |
Coming from #2321 (comment)
This PR handles
I preferred
exportoverpip compile. It doesn't seem there are any functional differences between two approaches, it just felt more uv-native.It seems we can't use hashes. With hashes,
pip installfails withI also made use of uv-pre-commit hook to ensure output files are always synchronized with the pyproject.toml file.
Overall, the PR introduces a new pyproject.toml based setup for managing dependencies and project settings, without breaking the existing tooling built on
requirements/folder.